shumengya/sproutclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent): dedupe symlinked resources (#3818)

Browse Source 
* fix(coding-agent): dedupe symlinked resources

Fixes #3767

* refactor(coding-agent): extract canonicalizePath util for symlink resolution
This commit is contained in:
Aliou Diallo
2026-04-27 18:33:10 +02:00
committed by GitHub
parent 6a10c17219
commit 10425abb87
8 changed files with 215 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
packages/coding-agent/test/resource-loader.test.ts
View File

@@ -1,4 +1,4 @@
import { mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { mkdirSync, readFileSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { afterEach, beforeEach, describe, expect, it } from "vitest";
@@ -156,6 +156,36 @@ Project skill`,
expect(theme?.sourcePath).toBe(projectThemePath);
});
it("should load symlinked user and project extensions once", async () => {
const sharedExtDir = join(tempDir, "shared-extensions");
mkdirSync(sharedExtDir, { recursive: true });
writeFileSync(
join(sharedExtDir, "shared.ts"),
`export default function(pi) {
pi.registerCommand("shared", {
description: "shared command",
handler: async () => {},
});
}`,
);
mkdirSync(agentDir, { recursive: true });
mkdirSync(join(cwd, ".pi"), { recursive: true });
symlinkSync(sharedExtDir, join(agentDir, "extensions"), "dir");
symlinkSync(sharedExtDir, join(cwd, ".pi", "extensions"), "dir");
const loader = new DefaultResourceLoader({ cwd, agentDir });
await loader.reload();
const extensionsResult = loader.getExtensions();
expect(extensionsResult.extensions).toHaveLength(1);
expect(extensionsResult.errors).toEqual([]);
// mergePaths processes project paths before user paths, so the project
// alias is the canonical survivor.
expect(extensionsResult.extensions[0].path).toBe(join(cwd, ".pi", "extensions", "shared.ts"));
});
it("should keep both extensions loaded when command names collide", async () => {
const userExtDir = join(agentDir, "extensions");
const projectExtDir = join(cwd, ".pi", "extensions");