shumengya/sproutclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(coding-agent): Add sessionDir support in settings.json (#2598)

Browse Source 
Users can now set sessionDir in global or project settings.json instead
of passing --session-dir on every invocation. CLI flag takes precedence,
then settings.json, then extension hooks.

Closes #2429

Co-authored-by: Sam Collins <81678+smcllns@users.noreply.github.com>
Co-authored-by: Mario Zechner <badlogicgames@gmail.com>
This commit is contained in:
Sam
2026-03-25 16:03:36 -07:00
committed by GitHub
parent d38ad0cd6b
commit 2b1fc90cd7
4 changed files with 47 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/coding-agent/src/core/settings-manager.ts
View File

@@ -94,6 +94,7 @@ export interface Settings {
autocompleteMaxVisible?: number; // Max visible items in autocomplete dropdown (default: 5)
showHardwareCursor?: boolean; // Show terminal cursor while still positioning it for IME
markdown?: MarkdownSettings;
sessionDir?: string; // Custom session storage directory (same format as --session-dir CLI flag)
}
/** Deep merge settings: project/overrides take precedence, nested objects merge recursively */
@@ -530,6 +531,10 @@ export class SettingsManager {
this.save();
}
getSessionDir(): string | undefined {
return this.settings.sessionDir;
}
getDefaultProvider(): string | undefined {
return this.settings.defaultProvider;
}

16
packages/coding-agent/src/main.ts
View File

@@ -439,16 +439,15 @@ async function createSessionManager(
parsed: Args,
cwd: string,
extensions: LoadExtensionsResult,
settingsManager: SettingsManager,
): Promise<SessionManager | undefined> {
if (parsed.noSession) {
return SessionManager.inMemory();
}
// CLI flag takes precedence, otherwise ask extensions for custom session directory
let effectiveSessionDir = parsed.sessionDir;
if (!effectiveSessionDir) {
effectiveSessionDir = await callSessionDirectoryHook(extensions, cwd);
}
// Priority: CLI flag > settings.json > extension hook
const effectiveSessionDir =
parsed.sessionDir ?? settingsManager.getSessionDir() ?? (await callSessionDirectoryHook(extensions, cwd));
if (parsed.fork) {
const resolved = await resolveSessionPath(parsed.fork, cwd, effectiveSessionDir);
@@ -789,13 +788,16 @@ export async function main(args: string[]) {
time("resolveModelScope");
// Create session manager based on CLI flags
let sessionManager = await createSessionManager(parsed, cwd, extensionsResult);
let sessionManager = await createSessionManager(parsed, cwd, extensionsResult,
time("createSessionManager");
// Handle --resume: show session picker
if (parsed.resume) {
// Compute effective session dir for resume (same logic as createSessionManager)
const effectiveSessionDir = parsed.sessionDir || (await callSessionDirectoryHook(extensionsResult, cwd));
const effectiveSessionDir =
parsed.sessionDir ??
settingsManager.getSessionDir() ??
(await callSessionDirectoryHook(extensionsResult, cwd));
const selectedPath = await selectSession(
(onProgress) => SessionManager.list(cwd, effectiveSessionDir, onProgress),