shumengya/sproutclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(coding-agent): bypass age gates for self-update

Browse Source 
closes #4929
This commit is contained in:
Armin Ronacher
2026-05-27 00:59:09 +02:00
parent 4402100830
commit 59ec8003db
3 changed files with 58 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/coding-agent/CHANGELOG.md
View File

@@ -4,6 +4,7 @@
### Fixed ### Fixed
- Fixed self-update commands to bypass npm, pnpm, and Bun minimum release age gates for explicit `pi update` runs ([#4929](https://github.com/earendil-works/pi/issues/4929)).
- Fixed context token estimates to count user image attachments consistently with tool result images ([#4983](https://github.com/earendil-works/pi/issues/4983)). - Fixed context token estimates to count user image attachments consistently with tool result images ([#4983](https://github.com/earendil-works/pi/issues/4983)).
- Fixed `RpcClient` to reject pending requests and consume stdin pipe errors when the child process exits unexpectedly ([#4764](https://github.com/earendil-works/pi/issues/4764)). - Fixed `RpcClient` to reject pending requests and consume stdin pipe errors when the child process exits unexpectedly ([#4764](https://github.com/earendil-works/pi/issues/4764)).
- Fixed managed npm extension updates to avoid package managers installing or resolving pi host packages as peer dependencies ([#4907](https://github.com/earendil-works/pi/issues/4907)). - Fixed managed npm extension updates to avoid package managers installing or resolving pi host packages as peer dependencies ([#4907](https://github.com/earendil-works/pi/issues/4907)).

17
packages/coding-agent/src/config.ts
View File

@@ -111,7 +111,13 @@ function getSelfUpdateCommandForMethod(
return undefined; return undefined;
case "pnpm": case "pnpm":
return makeSelfUpdateCommand( return makeSelfUpdateCommand(
makeSelfUpdateCommandStep("pnpm", ["install", "-g", "--ignore-scripts", updatePackageName]), makeSelfUpdateCommandStep("pnpm", [
"install",
"-g",
"--ignore-scripts",
"--config.minimumReleaseAge=0",
updatePackageName,
]),
updatePackageName === installedPackageName updatePackageName === installedPackageName
? undefined ? undefined
: makeSelfUpdateCommandStep("pnpm", ["remove", "-g", installedPackageName]), : makeSelfUpdateCommandStep("pnpm", ["remove", "-g", installedPackageName]),
@@ -125,7 +131,13 @@ function getSelfUpdateCommandForMethod(
); );
case "bun": case "bun":
return makeSelfUpdateCommand( return makeSelfUpdateCommand(
makeSelfUpdateCommandStep("bun", ["install", "-g", "--ignore-scripts", updatePackageName]), makeSelfUpdateCommandStep("bun", [
"install",
"-g",
"--ignore-scripts",
"--minimum-release-age=0",
updatePackageName,
]),
updatePackageName === installedPackageName updatePackageName === installedPackageName
? undefined ? undefined
: makeSelfUpdateCommandStep("bun", ["uninstall", "-g", installedPackageName]), : makeSelfUpdateCommandStep("bun", ["uninstall", "-g", installedPackageName]),
@@ -139,6 +151,7 @@ function getSelfUpdateCommandForMethod(
"install", "install",
"-g", "-g",
"--ignore-scripts", "--ignore-scripts",
"--min-release-age=0",
updatePackageName, updatePackageName,
]); ]);
const uninstallStep = const uninstallStep =

65
packages/coding-agent/test/config.test.ts
View File

@@ -153,7 +153,7 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("pnpm"); expect(detectInstallMethod()).toBe("pnpm");
expect(getUpdateInstruction("@earendil-works/pi-coding-agent")).toBe( expect(getUpdateInstruction("@earendil-works/pi-coding-agent")).toBe(
"Run: pnpm install -g --ignore-scripts @earendil-works/pi-coding-agent", "Run: pnpm install -g --ignore-scripts --config.minimumReleaseAge=0 @earendil-works/pi-coding-agent",
); );
}); });
@@ -175,8 +175,16 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("npm"); expect(detectInstallMethod()).toBe("npm");
expect(command).toEqual({ expect(command).toEqual({
command: "npm", command: "npm",
args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "@earendil-works/pi-coding-agent"], args: [
display: `npm --prefix ${prefix} install -g --ignore-scripts @earendil-works/pi-coding-agent`, "--prefix",
prefix,
"install",
"-g",
"--ignore-scripts",
"--min-release-age=0",
"@earendil-works/pi-coding-agent",
],
display: `npm --prefix ${prefix} install -g --ignore-scripts --min-release-age=0 @earendil-works/pi-coding-agent`,
}); });
}); });
@@ -187,8 +195,8 @@ describe("detectInstallMethod", () => {
expect(command).toEqual({ expect(command).toEqual({
command: "npm", command: "npm",
args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "--min-release-age=0", "@new-scope/pi"],
display: `npm --prefix ${prefix} uninstall -g @mariozechner/pi-coding-agent && npm --prefix ${prefix} install -g --ignore-scripts @new-scope/pi`, display: `npm --prefix ${prefix} uninstall -g @mariozechner/pi-coding-agent && npm --prefix ${prefix} install -g --ignore-scripts --min-release-age=0 @new-scope/pi`,
steps: [ steps: [
{ {
command: "npm", command: "npm",
@@ -197,8 +205,8 @@ describe("detectInstallMethod", () => {
}, },
{ {
command: "npm", command: "npm",
args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "--min-release-age=0", "@new-scope/pi"],
display: `npm --prefix ${prefix} install -g --ignore-scripts @new-scope/pi`, display: `npm --prefix ${prefix} install -g --ignore-scripts --min-release-age=0 @new-scope/pi`,
}, },
], ],
}); });
@@ -211,8 +219,16 @@ describe("detectInstallMethod", () => {
expect(command).toEqual({ expect(command).toEqual({
command: "npm", command: "npm",
args: ["--prefix", prefix, "install", "-g", "--ignore-scripts", "@earendil-works/pi-coding-agent"], args: [
display: `npm --prefix ${prefix} install -g --ignore-scripts @earendil-works/pi-coding-agent`, "--prefix",
prefix,
"install",
"-g",
"--ignore-scripts",
"--min-release-age=0",
"@earendil-works/pi-coding-agent",
],
display: `npm --prefix ${prefix} install -g --ignore-scripts --min-release-age=0 @earendil-works/pi-coding-agent`,
}); });
}); });
@@ -227,6 +243,7 @@ describe("detectInstallMethod", () => {
"install", "install",
"-g", "-g",
"--ignore-scripts", "--ignore-scripts",
"--min-release-age=0",
"@earendil-works/pi-coding-agent", "@earendil-works/pi-coding-agent",
]); ]);
}); });
@@ -237,7 +254,7 @@ describe("detectInstallMethod", () => {
const command = getSelfUpdateCommand("@earendil-works/pi-coding-agent"); const command = getSelfUpdateCommand("@earendil-works/pi-coding-agent");
expect(command?.display).toBe( expect(command?.display).toBe(
`npm --prefix "${prefix}" install -g --ignore-scripts @earendil-works/pi-coding-agent`, `npm --prefix "${prefix}" install -g --ignore-scripts --min-release-age=0 @earendil-works/pi-coding-agent`,
); );
}); });
@@ -248,7 +265,7 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("npm"); expect(detectInstallMethod()).toBe("npm");
expect(getUpdateInstruction("@earendil-works/pi-coding-agent")).toBe( expect(getUpdateInstruction("@earendil-works/pi-coding-agent")).toBe(
"Run: npm install -g --ignore-scripts @earendil-works/pi-coding-agent", "Run: npm install -g --ignore-scripts --min-release-age=0 @earendil-works/pi-coding-agent",
); );
}); });
@@ -260,8 +277,8 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("bun"); expect(detectInstallMethod()).toBe("bun");
expect(command).toEqual({ expect(command).toEqual({
command: "bun", command: "bun",
args: ["install", "-g", "--ignore-scripts", "@earendil-works/pi-coding-agent"], args: ["install", "-g", "--ignore-scripts", "--minimum-release-age=0", "@earendil-works/pi-coding-agent"],
display: "bun install -g --ignore-scripts @earendil-works/pi-coding-agent", display: "bun install -g --ignore-scripts --minimum-release-age=0 @earendil-works/pi-coding-agent",
}); });
}); });
@@ -273,8 +290,9 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("pnpm"); expect(detectInstallMethod()).toBe("pnpm");
expect(command).toEqual({ expect(command).toEqual({
command: "pnpm", command: "pnpm",
args: ["install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["install", "-g", "--ignore-scripts", "--config.minimumReleaseAge=0", "@new-scope/pi"],
display: "pnpm remove -g @mariozechner/pi-coding-agent && pnpm install -g --ignore-scripts @new-scope/pi", display:
"pnpm remove -g @mariozechner/pi-coding-agent && pnpm install -g --ignore-scripts --config.minimumReleaseAge=0 @new-scope/pi",
steps: [ steps: [
{ {
command: "pnpm", command: "pnpm",
@@ -283,8 +301,8 @@ describe("detectInstallMethod", () => {
}, },
{ {
command: "pnpm", command: "pnpm",
args: ["install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["install", "-g", "--ignore-scripts", "--config.minimumReleaseAge=0", "@new-scope/pi"],
display: "pnpm install -g --ignore-scripts @new-scope/pi", display: "pnpm install -g --ignore-scripts --config.minimumReleaseAge=0 @new-scope/pi",
}, },
], ],
}); });
@@ -328,8 +346,8 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("pnpm"); expect(detectInstallMethod()).toBe("pnpm");
expect(command).toEqual({ expect(command).toEqual({
command: "pnpm", command: "pnpm",
args: ["install", "-g", "--ignore-scripts", packageName], args: ["install", "-g", "--ignore-scripts", "--config.minimumReleaseAge=0", packageName],
display: `pnpm install -g --ignore-scripts ${packageName}`, display: `pnpm install -g --ignore-scripts --config.minimumReleaseAge=0 ${packageName}`,
}); });
}); });
@@ -366,8 +384,9 @@ describe("detectInstallMethod", () => {
expect(detectInstallMethod()).toBe("bun"); expect(detectInstallMethod()).toBe("bun");
expect(command).toEqual({ expect(command).toEqual({
command: "bun", command: "bun",
args: ["install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["install", "-g", "--ignore-scripts", "--minimum-release-age=0", "@new-scope/pi"],
display: "bun uninstall -g @mariozechner/pi-coding-agent && bun install -g --ignore-scripts @new-scope/pi", display:
"bun uninstall -g @mariozechner/pi-coding-agent && bun install -g --ignore-scripts --minimum-release-age=0 @new-scope/pi",
steps: [ steps: [
{ {
command: "bun", command: "bun",
@@ -376,8 +395,8 @@ describe("detectInstallMethod", () => {
}, },
{ {
command: "bun", command: "bun",
args: ["install", "-g", "--ignore-scripts", "@new-scope/pi"], args: ["install", "-g", "--ignore-scripts", "--minimum-release-age=0", "@new-scope/pi"],
display: "bun install -g --ignore-scripts @new-scope/pi", display: "bun install -g --ignore-scripts --minimum-release-age=0 @new-scope/pi",
}, },
], ],
}); });