fix(coding-agent): avoid Windows self-update native locks

closes #4157
This commit is contained in:
Armin Ronacher
2026-05-18 08:37:43 +02:00
parent 93b2e7fae7
commit 89b64d9dd5
4 changed files with 118 additions and 1 deletions

View File

@@ -3,7 +3,9 @@ import { spawn } from "child_process";
import { selectConfig } from "./cli/config-selector.js";
import {
APP_NAME,
detectInstallMethod,
getAgentDir,
getPackageDir,
getSelfUpdateCommand,
getSelfUpdateUnavailableInstruction,
PACKAGE_NAME,
@@ -14,6 +16,10 @@ import { DefaultPackageManager } from "./core/package-manager.js";
import { SettingsManager } from "./core/settings-manager.js";
import { resolveSpawnCommand } from "./utils/child-process.js";
import { getLatestPiRelease, isNewerPackageVersion } from "./utils/version-check.js";
import {
cleanupWindowsSelfUpdateQuarantine,
quarantineWindowsNativeDependencies,
} from "./utils/windows-self-update.js";
export type PackageCommand = "install" | "remove" | "update" | "list";
@@ -336,6 +342,16 @@ async function runSelfUpdate(command: SelfUpdateCommand): Promise<void> {
}
}
function prepareWindowsNpmSelfUpdate(): void {
if (process.platform !== "win32") {
return;
}
const packageDir = getPackageDir();
cleanupWindowsSelfUpdateQuarantine(packageDir);
quarantineWindowsNativeDependencies(packageDir);
}
export async function handleConfigCommand(args: string[]): Promise<boolean> {
if (args[0] !== "config") {
return false;
@@ -489,6 +505,13 @@ export async function handlePackageCommand(args: string[]): Promise<boolean> {
if (!selfUpdatePlan.shouldRun) {
return true;
}
const installMethod = detectInstallMethod();
if (process.platform === "win32" && installMethod !== "npm") {
console.error(chalk.red(`${APP_NAME} self-update on Windows is only supported for npm installs.`));
console.error(chalk.dim(`Detected install method: ${installMethod}. Update ${APP_NAME} manually.`));
process.exitCode = 1;
return true;
}
const selfUpdateCommand = getSelfUpdateCommand(
PACKAGE_NAME,
selfUpdateNpmCommand,
@@ -500,6 +523,7 @@ export async function handlePackageCommand(args: string[]): Promise<boolean> {
return true;
}
try {
prepareWindowsNpmSelfUpdate();
await runSelfUpdate(selfUpdateCommand);
} catch (error: unknown) {
const message = error instanceof Error ? error.message : "Unknown package command error";