refactor: use configurable keybindings for all UI hints (#724)

Follow-up to #717. Replaces all remaining hardcoded keybinding hints with configurable ones.

- Add pasteImage to AppAction so it can be configured in keybindings.json
- Create keybinding-hints.ts with reusable helper functions:
  - editorKey(action) / appKey(keybindings, action) - get key display string
  - keyHint(action, desc) / appKeyHint(kb, action, desc) / rawKeyHint(key, desc) - styled hints
- Export helpers from components/index.ts for extensions
- Update all components to use configured keybindings
- Remove now-unused getDisplayString() from KeybindingsManager and EditorKeybindingsManager
- Use keybindings.matches() instead of matchesKey() for pasteImage in custom-editor.ts
This commit is contained in:
Danila Poyarkov
2026-01-14 17:42:03 +03:00
committed by GitHub
parent 558a77b45f
commit a497fccd06
15 changed files with 195 additions and 170 deletions

View File

@@ -2,7 +2,7 @@
* Component for displaying bash command execution with streaming output.
*/
import { Container, getEditorKeybindings, Loader, Spacer, Text, type TUI } from "@mariozechner/pi-tui";
import { Container, Loader, Spacer, Text, type TUI } from "@mariozechner/pi-tui";
import stripAnsi from "strip-ansi";
import {
DEFAULT_MAX_BYTES,
@@ -12,6 +12,7 @@ import {
} from "../../../core/tools/truncate.js";
import { theme } from "../theme/theme.js";
import { DynamicBorder } from "./dynamic-border.js";
import { editorKey, keyHint } from "./keybinding-hints.js";
import { truncateToVisualLines } from "./visual-truncate.js";
// Preview line limit when not expanded (matches tool execution behavior)
@@ -57,7 +58,7 @@ export class BashExecutionComponent extends Container {
ui,
(spinner) => theme.fg(colorKey, spinner),
(text) => theme.fg("muted", text),
"Running... (esc to cancel)",
`Running... (${editorKey("selectCancel")} to cancel)`, // Plain text for loader
);
this.contentContainer.addChild(this.loader);
@@ -166,14 +167,11 @@ export class BashExecutionComponent extends Container {
// Show how many lines are hidden (collapsed preview)
if (hiddenLineCount > 0) {
const expandKey = getEditorKeybindings().getKeys("expandTools")[0]!;
if (this.expanded) {
statusParts.push(`(${theme.fg("dim", expandKey)}${theme.fg("muted", " to collapse")})`);
statusParts.push(`(${keyHint("expandTools", "to collapse")})`);
} else {
statusParts.push(
theme.fg("muted", `... ${hiddenLineCount} more lines (`) +
theme.fg("dim", expandKey) +
theme.fg("muted", " to expand)"),
`${theme.fg("muted", `... ${hiddenLineCount} more lines`)} (${keyHint("expandTools", "to expand")})`,
);
}
}