shumengya/sproutclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tui): preserve ASCII punctuation word boundaries with Intl.Segmenter (#5067)

Browse Source
This commit is contained in:
xu0o0
2026-05-27 18:12:10 +08:00
committed by GitHub
parent 493efd422d
commit b62776e4a2
4 changed files with 66 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
packages/tui/test/editor.test.ts
View File

@@ -532,6 +532,15 @@ describe("Editor component", () => {
editor.handleInput("\x17");
assert.strictEqual(editor.getText(), "foo bar");
// ASCII punctuation inside Intl word-like segments preserves old boundaries
editor.setText("foo.bar");
editor.handleInput("\x17");
assert.strictEqual(editor.getText(), "foo.");
editor.setText("foo:bar");
editor.handleInput("\x17");
assert.strictEqual(editor.getText(), "foo:");
// Delete across multiple lines
editor.setText("line one\nline two");
editor.handleInput("\x17");
@@ -590,6 +599,23 @@ describe("Editor component", () => {
editor.handleInput("\x01"); // Ctrl+A to go to start
editor.handleInput("\x1b[1;5C"); // Ctrl+Right
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 6 }); // after 'foo'
// ASCII punctuation inside Intl word-like segments preserves old boundaries
editor.setText("foo.bar baz");
editor.handleInput("\x1b[1;5D"); // Ctrl+Left over baz
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 8 });
editor.handleInput("\x1b[1;5D"); // Ctrl+Left over bar
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 4 });
editor.handleInput("\x1b[1;5D"); // Ctrl+Left over .
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 3 });
editor.handleInput("\x01"); // Ctrl+A
editor.handleInput("\x1b[1;5C"); // Ctrl+Right over foo
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 3 });
editor.handleInput("\x1b[1;5C"); // Ctrl+Right over .
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 4 });
editor.handleInput("\x1b[1;5C"); // Ctrl+Right over bar
assert.deepStrictEqual(editor.getCursor(), { line: 0, col: 7 });
});
it("stops at fullwidth Chinese punctuation (issue #4972)", () => {

14
packages/tui/test/input.test.ts
View File

@@ -100,6 +100,20 @@ describe("Input component", () => {
assert.strictEqual(input.getValue(), "bazfoo bar ");
});
it("Ctrl+W preserves ASCII punctuation boundaries", () => {
const input = new Input();
input.setValue("foo.bar");
input.handleInput("\x05"); // Ctrl+E
input.handleInput("\x17"); // Ctrl+W - deletes "bar"
assert.strictEqual(input.getValue(), "foo.");
input.setValue("foo:bar");
input.handleInput("\x05"); // Ctrl+E
input.handleInput("\x17"); // Ctrl+W - deletes "bar"
assert.strictEqual(input.getValue(), "foo:");
});
it("Ctrl+U saves deleted text to kill ring", () => {
const input = new Input();