Clean up OAuth device-code callbacks

packages/ai/src/cli.ts

@@ -50,6 +50,15 @@ async function login(providerId: OAuthProviderId): Promise<void> {
 			onPrompt: async (p) => {
 				return await promptFn(`${p.message}${p.placeholder ? ` (${p.placeholder})` : ""}:`);
 			},
+			onSelect: async (p) => {
+				console.log(`\n${p.message}`);
+				for (let i = 0; i < p.options.length; i++) {
+					console.log(`  ${i + 1}. ${p.options[i].label}`);
+				}
+				const choice = await promptFn(`Enter number (1-${p.options.length}):`);
+				const index = parseInt(choice, 10) - 1;
+				return p.options[index]?.id;
+			},
 			onProgress: (msg) => console.log(msg),
 		});
 

packages/ai/src/utils/oauth/github-copilot.ts

@@ -319,10 +319,6 @@ export const githubCopilotOAuthProvider: OAuthProviderInterface = {
 	name: "GitHub Copilot",
 
 	async login(callbacks: OAuthLoginCallbacks): Promise<OAuthCredentials> {
-		if (!callbacks.onDeviceCode) {
-			throw new Error("GitHub Copilot OAuth requires a device code callback");
-		}
-
 		return loginGitHubCopilot({
 			onDeviceCode: callbacks.onDeviceCode,
 			onPrompt: callbacks.onPrompt,

packages/ai/src/utils/oauth/types.ts

@@ -42,12 +42,12 @@ export type OAuthSelectPrompt = {
 
 export interface OAuthLoginCallbacks {
 	onAuth: (info: OAuthAuthInfo) => void;
-	onDeviceCode?: (info: OAuthDeviceCodeInfo) => void;
+	onDeviceCode: (info: OAuthDeviceCodeInfo) => void;
 	onPrompt: (prompt: OAuthPrompt) => Promise<string>;
 	onProgress?: (message: string) => void;
 	onManualCodeInput?: () => Promise<string>;
 	/** Show an interactive selector and return the selected option id, or undefined on cancel. */
-	onSelect?: (prompt: OAuthSelectPrompt) => Promise<string | undefined>;
+	onSelect: (prompt: OAuthSelectPrompt) => Promise<string | undefined>;
 	signal?: AbortSignal;
 }