shumengya/sproutclaw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(agent): return diagnostics from resource loaders

Browse Source
This commit is contained in:
Mario Zechner
2026-05-06 21:59:48 +02:00
parent 617d8b317d
commit ddb18640e3
5 changed files with 258 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
packages/agent/test/harness/skills.test.ts
View File

@@ -2,7 +2,7 @@ import { symlink } from "node:fs/promises";
import { join } from "node:path";
import { describe, expect, it } from "vitest";
import { NodeExecutionEnv } from "../../src/harness/execution-env.js";
import { loadSkills } from "../../src/harness/skills.js";
import { loadSkills, loadSourcedSkills } from "../../src/harness/skills.js";
import { createTempDir } from "./session-test-utils.js";
describe("loadSkills", () => {
@@ -21,8 +21,9 @@ Use this skill.
`,
);
const skills = await loadSkills(env, ".agents/skills");
const { skills, diagnostics } = await loadSkills(env, ".agents/skills");
expect(diagnostics).toEqual([]);
expect(skills).toEqual([
{
name: "example",
@@ -44,12 +45,61 @@ Use this skill.
);
await symlink(join(root, "actual"), join(root, "skills-link"));
const skills = await loadSkills(env, "skills-link");
const { skills } = await loadSkills(env, "skills-link");
expect(skills.map((skill) => skill.name)).toEqual(["example"]);
expect(skills[0]?.filePath).toBe(join(root, "skills-link/example/SKILL.md"));
});
it("preserves source info for sourced skills", async () => {
const root = createTempDir();
const env = new NodeExecutionEnv({ cwd: root });
await env.createDir("user/example", { recursive: true });
await env.writeFile(
"user/example/SKILL.md",
"---\nname: example\ndescription: Example skill\n---\nUse this skill.",
);
const { skills, diagnostics } = await loadSourcedSkills(env, [
{ path: "user", source: { type: "user" as const } },
]);
expect(diagnostics).toEqual([]);
expect(skills).toEqual([
{
skill: {
name: "example",
description: "Example skill",
content: "Use this skill.",
filePath: join(root, "user/example/SKILL.md"),
disableModelInvocation: false,
},
source: { type: "user" },
},
]);
});
it("attaches source info to diagnostics", async () => {
const root = createTempDir();
const env = new NodeExecutionEnv({ cwd: root });
await env.createDir("user/broken", { recursive: true });
await env.writeFile("user/broken/SKILL.md", "---\nname: broken\n---\nMissing description.");
const { skills, diagnostics } = await loadSourcedSkills(env, [
{ path: "user", source: { type: "user" as const } },
]);
expect(skills).toEqual([]);
expect(diagnostics).toEqual([
{
type: "warning",
message: "description is required",
path: join(root, "user/broken/SKILL.md"),
source: { type: "user" },
},
]);
});
it("loads direct markdown children only from the root directory", async () => {
const root = createTempDir();
const env = new NodeExecutionEnv({ cwd: root });
@@ -57,7 +107,7 @@ Use this skill.
await env.writeFile("skills/root.md", "---\ndescription: Root skill\n---\nRoot content");
await env.writeFile("skills/nested/ignored.md", "---\ndescription: Ignored\n---\nIgnored content");
const skills = await loadSkills(env, "skills");
const { skills } = await loadSkills(env, "skills");
expect(skills.map((skill) => skill.name)).toEqual(["skills"]);
expect(skills[0]?.content).toBe("Root content");