test(agent): pin harness resource formatting

packages/agent/test/harness/system-prompt.test.ts

@@ -1,45 +1,66 @@
 import { describe, expect, it } from "vitest";
 import { formatSkillsForSystemPrompt } from "../../src/harness/system-prompt.js";
 
+const visibleSkill = {
+	name: "visible",
+	description: "Use <this> & that",
+	content: "visible content",
+	filePath: "/skills/visible/SKILL.md",
+};
+
+const secondSkill = {
+	name: "second",
+	description: "Second skill",
+	content: "second content",
+	filePath: "/skills/second/SKILL.md",
+};
+
+const disabledSkill = {
+	name: "hidden",
+	description: "Hidden",
+	content: "hidden content",
+	filePath: "/skills/hidden/SKILL.md",
+	disableModelInvocation: true,
+};
+
 describe("formatSkillsForSystemPrompt", () => {
-	it("formats visible skills and skips model-disabled skills", () => {
+	it("formats visible skills in order and skips model-disabled skills", () => {
+		expect(formatSkillsForSystemPrompt([visibleSkill, disabledSkill, secondSkill])).toBe(
+			`The following skills provide specialized instructions for specific tasks.
+Read the full skill file when the task matches its description.
+When a skill file references a relative path, resolve it against the skill directory (parent of SKILL.md / dirname of the path) and use that absolute path in tool commands.
+
+<available_skills>
+  <skill>
+    <name>visible</name>
+    <description>Use &lt;this&gt; &amp; that</description>
+    <location>/skills/visible/SKILL.md</location>
+  </skill>
+  <skill>
+    <name>second</name>
+    <description>Second skill</description>
+    <location>/skills/second/SKILL.md</location>
+  </skill>
+</available_skills>`,
+		);
+	});
+
+	it("returns an empty string when no skills are model-visible", () => {
+		expect(formatSkillsForSystemPrompt([disabledSkill])).toBe("");
+	});
+
+	it("escapes XML in all model-visible skill fields", () => {
 		expect(
 			formatSkillsForSystemPrompt([
 				{
-					name: "visible",
-					description: "Use <this> & that",
-					content: "visible content",
-					filePath: "/skills/visible/SKILL.md",
-				},
-				{
-					name: "hidden",
-					description: "Hidden",
-					content: "hidden content",
-					filePath: "/skills/hidden/SKILL.md",
-					disableModelInvocation: true,
+					name: "a&b",
+					description: `Quote "double" and 'single'`,
+					content: "content",
+					filePath: '/skills/<bad>&"quote"/SKILL.md',
 				},
 			]),
-		).toContain("<name>visible</name>");
-		expect(
-			formatSkillsForSystemPrompt([
-				{
-					name: "visible",
-					description: "Use <this> & that",
-					content: "visible content",
-					filePath: "/skills/visible/SKILL.md",
-				},
-			]),
-		).toContain("Use &lt;this&gt; &amp; that");
-		expect(
-			formatSkillsForSystemPrompt([
-				{
-					name: "hidden",
-					description: "Hidden",
-					content: "hidden content",
-					filePath: "/skills/hidden/SKILL.md",
-					disableModelInvocation: true,
-				},
-			]),
-		).toBe("");
+		).toContain(
+			"<name>a&amp;b</name>\n    <description>Quote &quot;double&quot; and &apos;single&apos;</description>\n    <location>/skills/&lt;bad&gt;&amp;&quot;quote&quot;/SKILL.md</location>",
+		);
 	});
 });