30a8a41fc3
OSC 8 hyperlinks landed in #3248, but detectCapabilities() returned hyperlinks: true in the unknown-terminal fallback. Terminals that silently swallow OSC 8 (most xterm-compatible hosts, tmux/screen without passthrough) end up dropping the URL from rendered markdown links entirely, since the fallback 'text (url)' rendering is skipped whenever hyperlinks is true. - Unknown terminals now default to hyperlinks: false. - tmux and screen (TMUX env, TERM starting with tmux/screen) force hyperlinks: false even when the outer terminal would otherwise advertise OSC 8 support. Image protocols also left disabled. - Added detectCapabilities tests covering the known-capable set and the tmux/screen/unknown cases.
280 lines
10 KiB
TypeScript
280 lines
10 KiB
TypeScript
/**
|
|
* Tests for terminal image detection and line handling
|
|
*/
|
|
|
|
import assert from "node:assert";
|
|
import { describe, it } from "node:test";
|
|
import { detectCapabilities, hyperlink, isImageLine } from "../src/terminal-image.js";
|
|
|
|
const ENV_KEYS = [
|
|
"TERM",
|
|
"TERM_PROGRAM",
|
|
"COLORTERM",
|
|
"TMUX",
|
|
"KITTY_WINDOW_ID",
|
|
"GHOSTTY_RESOURCES_DIR",
|
|
"WEZTERM_PANE",
|
|
"ITERM_SESSION_ID",
|
|
] as const;
|
|
|
|
function withEnv(overrides: Record<string, string | undefined>, fn: () => void): void {
|
|
const saved: Record<string, string | undefined> = {};
|
|
for (const key of ENV_KEYS) {
|
|
saved[key] = process.env[key];
|
|
delete process.env[key];
|
|
}
|
|
try {
|
|
for (const [k, v] of Object.entries(overrides)) {
|
|
if (v === undefined) delete process.env[k];
|
|
else process.env[k] = v;
|
|
}
|
|
fn();
|
|
} finally {
|
|
for (const key of ENV_KEYS) {
|
|
if (saved[key] === undefined) delete process.env[key];
|
|
else process.env[key] = saved[key];
|
|
}
|
|
}
|
|
}
|
|
|
|
describe("isImageLine", () => {
|
|
describe("iTerm2 image protocol", () => {
|
|
it("should detect iTerm2 image escape sequence at start of line", () => {
|
|
// iTerm2 image escape sequence: ESC ]1337;File=...
|
|
const iterm2ImageLine = "\x1b]1337;File=size=100,100;inline=1:base64encodeddata==\x07";
|
|
assert.strictEqual(isImageLine(iterm2ImageLine), true);
|
|
});
|
|
|
|
it("should detect iTerm2 image escape sequence with text before it", () => {
|
|
// Simulating a line that has text then image data (bug scenario)
|
|
const lineWithTextAndImage = "Some text \x1b]1337;File=size=100,100;inline=1:base64data==\x07 more text";
|
|
assert.strictEqual(isImageLine(lineWithTextAndImage), true);
|
|
});
|
|
|
|
it("should detect iTerm2 image escape sequence in middle of long line", () => {
|
|
// Simulate a very long line with image data in the middle
|
|
const longLineWithImage =
|
|
"Text before image..." + "\x1b]1337;File=inline=1:verylongbase64data==" + "...text after";
|
|
assert.strictEqual(isImageLine(longLineWithImage), true);
|
|
});
|
|
|
|
it("should detect iTerm2 image escape sequence at end of line", () => {
|
|
const lineWithImageAtEnd = "Regular text ending with \x1b]1337;File=inline=1:base64data==\x07";
|
|
assert.strictEqual(isImageLine(lineWithImageAtEnd), true);
|
|
});
|
|
|
|
it("should detect minimal iTerm2 image escape sequence", () => {
|
|
const minimalImageLine = "\x1b]1337;File=:\x07";
|
|
assert.strictEqual(isImageLine(minimalImageLine), true);
|
|
});
|
|
});
|
|
|
|
describe("Kitty image protocol", () => {
|
|
it("should detect Kitty image escape sequence at start of line", () => {
|
|
// Kitty image escape sequence: ESC _G
|
|
const kittyImageLine = "\x1b_Ga=T,f=100,t=f,d=base64data...\x1b\\\x1b_Gm=i=1;\x1b\\";
|
|
assert.strictEqual(isImageLine(kittyImageLine), true);
|
|
});
|
|
|
|
it("should detect Kitty image escape sequence with text before it", () => {
|
|
// Bug scenario: text + image data in same line
|
|
const lineWithTextAndKittyImage = "Output: \x1b_Ga=T,f=100;data...\x1b\\\x1b_Gm=i=1;\x1b\\";
|
|
assert.strictEqual(isImageLine(lineWithTextAndKittyImage), true);
|
|
});
|
|
|
|
it("should detect Kitty image escape sequence with padding", () => {
|
|
// Kitty protocol adds padding to escape sequences
|
|
const kittyWithPadding = " \x1b_Ga=T,f=100...\x1b\\\x1b_Gm=i=1;\x1b\\ ";
|
|
assert.strictEqual(isImageLine(kittyWithPadding), true);
|
|
});
|
|
});
|
|
|
|
describe("Bug regression tests", () => {
|
|
it("should detect image sequences in very long lines (304k+ chars)", () => {
|
|
// This simulates the crash scenario: a line with 304,401 chars
|
|
// containing image escape sequences somewhere
|
|
const base64Char = "A".repeat(100); // 100 chars of base64-like data
|
|
const imageSequence = "\x1b]1337;File=size=800,600;inline=1:";
|
|
|
|
// Build a long line with image sequence
|
|
const longLine =
|
|
"Text prefix " +
|
|
imageSequence +
|
|
base64Char.repeat(3000) + // ~300,000 chars
|
|
" suffix";
|
|
|
|
assert.strictEqual(longLine.length > 300000, true);
|
|
assert.strictEqual(isImageLine(longLine), true);
|
|
});
|
|
|
|
it("should detect image sequences when terminal doesn't support images", () => {
|
|
// The bug occurred when getImageEscapePrefix() returned null
|
|
// isImageLine should still detect image sequences regardless
|
|
const lineWithImage = "Read image file [image/jpeg]\x1b]1337;File=inline=1:base64data==\x07";
|
|
assert.strictEqual(isImageLine(lineWithImage), true);
|
|
});
|
|
|
|
it("should detect image sequences with ANSI codes before them", () => {
|
|
// Text might have ANSI styling before image data
|
|
const lineWithAnsiAndImage = "\x1b[31mError output \x1b]1337;File=inline=1:image==\x07";
|
|
assert.strictEqual(isImageLine(lineWithAnsiAndImage), true);
|
|
});
|
|
|
|
it("should detect image sequences with ANSI codes after them", () => {
|
|
const lineWithImageAndAnsi = "\x1b_Ga=T,f=100:data...\x1b\\\x1b_Gm=i=1;\x1b\\\x1b[0m reset";
|
|
assert.strictEqual(isImageLine(lineWithImageAndAnsi), true);
|
|
});
|
|
});
|
|
|
|
describe("Negative cases - lines without images", () => {
|
|
it("should not detect images in plain text lines", () => {
|
|
const plainText = "This is just a regular text line without any escape sequences";
|
|
assert.strictEqual(isImageLine(plainText), false);
|
|
});
|
|
|
|
it("should not detect images in lines with only ANSI codes", () => {
|
|
const ansiText = "\x1b[31mRed text\x1b[0m and \x1b[32mgreen text\x1b[0m";
|
|
assert.strictEqual(isImageLine(ansiText), false);
|
|
});
|
|
|
|
it("should not detect images in lines with cursor movement codes", () => {
|
|
const cursorCodes = "\x1b[1A\x1b[2KLine cleared and moved up";
|
|
assert.strictEqual(isImageLine(cursorCodes), false);
|
|
});
|
|
|
|
it("should not detect images in lines with partial iTerm2 sequences", () => {
|
|
// Similar prefix but missing the complete sequence
|
|
const partialSequence = "Some text with ]1337;File but missing ESC at start";
|
|
assert.strictEqual(isImageLine(partialSequence), false);
|
|
});
|
|
|
|
it("should not detect images in lines with partial Kitty sequences", () => {
|
|
// Similar prefix but missing the complete sequence
|
|
const partialSequence = "Some text with _G but missing ESC at start";
|
|
assert.strictEqual(isImageLine(partialSequence), false);
|
|
});
|
|
|
|
it("should not detect images in empty lines", () => {
|
|
assert.strictEqual(isImageLine(""), false);
|
|
});
|
|
|
|
it("should not detect images in lines with newlines only", () => {
|
|
assert.strictEqual(isImageLine("\n"), false);
|
|
assert.strictEqual(isImageLine("\n\n"), false);
|
|
});
|
|
});
|
|
|
|
describe("Mixed content scenarios", () => {
|
|
it("should detect images when line has both Kitty and iTerm2 sequences", () => {
|
|
const mixedLine = "Kitty: \x1b_Ga=T...\x1b\\\x1b_Gm=i=1;\x1b\\ iTerm2: \x1b]1337;File=inline=1:data==\x07";
|
|
assert.strictEqual(isImageLine(mixedLine), true);
|
|
});
|
|
|
|
it("should detect image in line with multiple text and image segments", () => {
|
|
const complexLine = "Start \x1b]1337;File=img1==\x07 middle \x1b]1337;File=img2==\x07 end";
|
|
assert.strictEqual(isImageLine(complexLine), true);
|
|
});
|
|
|
|
it("should not falsely detect image in line with file path containing keywords", () => {
|
|
// File path might contain "1337" or "File" but without escape sequences
|
|
const filePathLine = "/path/to/File_1337_backup/image.jpg";
|
|
assert.strictEqual(isImageLine(filePathLine), false);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("detectCapabilities", () => {
|
|
it("defaults to hyperlinks: false for unknown terminals", () => {
|
|
withEnv({}, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, false);
|
|
assert.strictEqual(caps.images, null);
|
|
});
|
|
});
|
|
|
|
it("forces hyperlinks: false under tmux even if outer terminal supports OSC 8", () => {
|
|
withEnv({ TMUX: "/tmp/tmux-1000/default,1234,0", TERM_PROGRAM: "ghostty" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, false);
|
|
assert.strictEqual(caps.images, null);
|
|
});
|
|
});
|
|
|
|
it("forces hyperlinks: false when TERM starts with 'tmux'", () => {
|
|
withEnv({ TERM: "tmux-256color", TERM_PROGRAM: "iterm.app" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, false);
|
|
assert.strictEqual(caps.images, null);
|
|
});
|
|
});
|
|
|
|
it("forces hyperlinks: false when TERM starts with 'screen'", () => {
|
|
withEnv({ TERM: "screen-256color" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, false);
|
|
assert.strictEqual(caps.images, null);
|
|
});
|
|
});
|
|
|
|
it("enables hyperlinks for Ghostty", () => {
|
|
withEnv({ TERM_PROGRAM: "ghostty" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, true);
|
|
});
|
|
});
|
|
|
|
it("enables hyperlinks for Kitty", () => {
|
|
withEnv({ KITTY_WINDOW_ID: "1" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, true);
|
|
});
|
|
});
|
|
|
|
it("enables hyperlinks for WezTerm", () => {
|
|
withEnv({ WEZTERM_PANE: "0" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, true);
|
|
});
|
|
});
|
|
|
|
it("enables hyperlinks for iTerm2", () => {
|
|
withEnv({ TERM_PROGRAM: "iterm.app" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, true);
|
|
});
|
|
});
|
|
|
|
it("enables hyperlinks for VSCode", () => {
|
|
withEnv({ TERM_PROGRAM: "vscode" }, () => {
|
|
const caps = detectCapabilities();
|
|
assert.strictEqual(caps.hyperlinks, true);
|
|
});
|
|
});
|
|
});
|
|
|
|
describe("hyperlink", () => {
|
|
it("wraps text in OSC 8 open and close sequences", () => {
|
|
const result = hyperlink("click me", "https://example.com");
|
|
assert.strictEqual(result, "\x1b]8;;https://example.com\x1b\\click me\x1b]8;;\x1b\\");
|
|
});
|
|
|
|
it("preserves ANSI styling inside the hyperlink", () => {
|
|
const styled = "\x1b[4m\x1b[34mclick me\x1b[0m";
|
|
const result = hyperlink(styled, "https://example.com");
|
|
assert.ok(result.startsWith("\x1b]8;;https://example.com\x1b\\"));
|
|
assert.ok(result.includes(styled));
|
|
assert.ok(result.endsWith("\x1b]8;;\x1b\\"));
|
|
});
|
|
|
|
it("works with empty text", () => {
|
|
const result = hyperlink("", "https://example.com");
|
|
assert.strictEqual(result, "\x1b]8;;https://example.com\x1b\\\x1b]8;;\x1b\\");
|
|
});
|
|
|
|
it("works with file:// URIs", () => {
|
|
const result = hyperlink("README.md", "file:///home/user/README.md");
|
|
assert.ok(result.includes("file:///home/user/README.md"));
|
|
assert.ok(result.includes("README.md"));
|
|
});
|
|
});
|