fix(coding-agent): use shell for external editor on windows closes #1925

This commit is contained in:
Mario Zechner
2026-03-08 00:48:33 +01:00
parent deb5fb3b88
commit ad11058e37
3 changed files with 3 additions and 0 deletions

View File

@@ -11,6 +11,7 @@
- Fixed tmux startup guidance and keyboard setup warnings for modified key handling, including Ghostty `shift+enter=text:\n` remap guidance and tmux `extended-keys-format` detection ([#1872](https://github.com/badlogic/pi-mono/issues/1872))
- Fixed z.ai context overflow recovery so `model_context_window_exceeded` errors trigger auto-compaction instead of surfacing as unhandled stop reason failures ([#1937](https://github.com/badlogic/pi-mono/issues/1937))
- Fixed explicit `pi -e <path>` extensions losing command and tool conflicts to discovered extensions by giving CLI-loaded extensions higher precedence ([#1896](https://github.com/badlogic/pi-mono/issues/1896))
- Fixed Windows external editor launch for `Ctrl+G` and `ctx.ui.editor()` so shell-based commands like `EDITOR="code --wait"` work correctly ([#1925](https://github.com/badlogic/pi-mono/issues/1925))
## [0.57.0] - 2026-03-07

View File

@@ -126,6 +126,7 @@ export class ExtensionEditorComponent extends Container implements Focusable {
const [editor, ...editorArgs] = editorCmd.split(" ");
const result = spawnSync(editor, [...editorArgs, tmpFile], {
stdio: "inherit",
shell: process.platform === "win32",
});
if (result.status === 0) {

View File

@@ -2817,6 +2817,7 @@ export class InteractiveMode {
// Spawn editor synchronously with inherited stdio for interactive editing
const result = spawnSync(editor, [...editorArgs, tmpFile], {
stdio: "inherit",
shell: process.platform === "win32",
});
// On successful exit (status 0), replace editor content